I see. I think the problem you're having in this case, is that your Custom Success URL is providing the Customer with a way to register ( i.e. there is a "Signup Now" link somewhere on your site ), which indicates to me that Open Registration is enabled in your s2Member configuration.
So your paying Customers are completing checkout, then you're redirecting them to a Custom Success URL where there is a link to register ( i.e. "Signup Now" ). Since your Custom Success URL is not handling Auto-Return/PDT data from PayPal, the Customer's registration comes through like any other public registration ( in other words, they come through as a Free Subscriber, even though they've paid you ).
In cases where a Customer is paying for access, the default s2Member Auto-Return handler will allow the Customer to register immediately after checkout, because it handles the authentication of paid registration access. However, if you handle this yourself through a Custom Success URL ( i.e. the
success="" Shortcode attribute ), you should simply provide the Customer with a Thank-You Page, and ask them to check their email for the link to register for paid access.
Possible solutions for you.1. Allow s2Member to handle the Auto-Return/PDT data for you.
( in other words, do NOT use the
success="" attribute, and let s2Member handle this for you )
2. Or, you can use the
success="" attribute, but on your Custom Success URL, ask the Customer to check their email for the link to register. The link that s2Member provides in the Signup Confirmation Email after checkout will work as expected.
3. Or, upgrade to using s2Member Pro Forms, where this is not an issue. With s2Member Pro Forms, Registration/Checkout is consolidated into a single step.
http://www.s2member.com/