PriMoThemes — now s2Member® (official notice)

This is now a very OLD forum system. It's in READ-ONLY mode.
All community interaction now occurs at WP Sharks™. See: new forums @ WP Sharks™

Pro Forms Not Sending First/Last Name to PayPal

s2Member Plugin. A Membership plugin for WordPress®.

Pro Forms Not Sending First/Last Name to PayPal

Postby smitchell360 » January 19th, 2011, 4:31 pm

When a user updates the First Name and Last Name fields on the purchase form (using S2Member Pro), the OLD values are passed to PayPal.

Anyone else getting this?
User avatar
smitchell360
Experienced User
Experienced User
 
Posts: 28
Joined: January 4, 2011

Re: Pro Forms Not Sending First/Last Name to PayPal

Postby smitchell360 » January 19th, 2011, 5:39 pm

Digging in the S2 code a bit...

Jason, in paypal-checkout.inc.php, lines 130 - 200, you are handling the case of user logged in with recurring billing purchase.

It looks like you are taking the $user->first_name and $user->last_name to set the paypal variables. Should you be getting these from the post_vars??

$paypal["FIRSTNAME"] = $post_vars["first_name"];
$paypal["LASTNAME"] = $post_vars["last_name"];
User avatar
smitchell360
Experienced User
Experienced User
 
Posts: 28
Joined: January 4, 2011

Re: Pro Forms Not Sending First/Last Name to PayPal

Postby smitchell360 » January 19th, 2011, 5:50 pm

Jason,

I am pretty sure that was/is the problem. In addition, I do not see any code to so the user update with this information. there is some code around line 375 that does a CREATE if the user is not logged in ... but the UPDATE code seems to be missing.

Can you verify this?
User avatar
smitchell360
Experienced User
Experienced User
 
Posts: 28
Joined: January 4, 2011

Re: Pro Forms Not Sending First/Last Name to PayPal

Postby Jason Caldwell » April 2nd, 2011, 2:01 pm

Thank you VERY much for reporting this.
~ and thanks Cristián for bringing this to my attention.

Sincere apologies for the delayed response.

Regarding Membership Billing Modifications with s2Member Pro Forms.
Yes, you are correct. We do need to update this routine so that First/Last is passed through as submitted instead of using the existing values on the account. However, this will only affect the purchase, and not the Member's Profile, because it's only needed for billing verification in this instance.

I'm having this corrected in the release of s2Member Pro v1.5.8.
~ Jason Caldwell / Lead Developer
& Zeitgeist Movie Advocate: http://www.zeitgeistmovie.com/

Is the s2Member plugin working for you? Please rate s2Member at WordPress.org.
You'll need a WordPress.org account ( comes in handy ). Then rate s2Member here Image
.
User avatar
Jason Caldwell
Lead Developer
Lead Developer
 
Posts: 4045
Joined: May 3, 2010
Location: Georgia / USA


Return to s2Member Plugin

Who is online

Users browsing this forum: No registered users and 2 guests

cron