PriMoThemes — now s2Member® (official notice)

This is now a very OLD forum system. It's in READ-ONLY mode.
All community interaction now occurs at WP Sharks™. See: new forums @ WP Sharks™

No password checking in profile form

s2Member Plugin. A Membership plugin for WordPress®.

No password checking in profile form

Postby man-O-media » March 23rd, 2011, 10:02 pm

Hi all...

s2member 3.5.5

I am using the s2 option to "Redirect Members away from the Default Profile Panel".
When a user goes to their profile and changes their password, there are two password fields but there is no password checking which compares the two fields.

You can enter a password in one field, leave the second field blank and save changes which changes the password to what was entered in the fist field.
You can enter two different passwords and save changes. This makes the first password the one which is active and no error comes up saying that the passwords don't match.

Clearly this is not what should be happening...

Daine
User avatar
man-O-media
Experienced User
Experienced User
 
Posts: 117
Joined: February 10, 2011

Re: No password checking in profile form

Postby Cristián Lávaque » March 23rd, 2011, 10:21 pm

Clearly not.

I wasn't able to reproduce it, though. My profile does show an error if the fields have different values.

Do you have other things installed that may be causing this behaviour? What other plugins?
Cristián Lávaque http://s2member.net
Is s2Member working for you? Please rate it Image at WordPress.org. Thanks! :)
User avatar
Cristián Lávaque
Developer
Developer
 
Posts: 6836
Joined: December 22, 2010

Re: No password checking in profile form

Postby Jason Caldwell » March 23rd, 2011, 10:59 pm

Yes, Cristián is correct. This is not the intended behavior. It sounds like you may have a JavaScript error being introduced by another plugin, or possibly by your theme. All it takes is one line of code in JavaScript that triggers a minor error, and it can render other JavaScript in your document void.

When the Passwords do not match up, you should get a JavaScript alert that reads:
Oops, you missed something:
Passwords do not match up. Please try again.

I would start by opening your site in Firefox. After loading up the Profile Editing panel, go up to Tools -> Error Console -> Errors. That may provide you with some insight.
~ Jason Caldwell / Lead Developer
& Zeitgeist Movie Advocate: http://www.zeitgeistmovie.com/

Is the s2Member plugin working for you? Please rate s2Member at WordPress.org.
You'll need a WordPress.org account ( comes in handy ). Then rate s2Member here Image
.
User avatar
Jason Caldwell
Lead Developer
Lead Developer
 
Posts: 4045
Joined: May 3, 2010
Location: Georgia / USA

Re: No password checking in profile form

Postby man-O-media » March 23rd, 2011, 11:14 pm

I'm not running anything that is very exciting, I don't think...

    Akismet - Version 2.5.3
    Contact Form 7 - Version 2.4.3 ( email form)
    Contact Form 7 widget - Version 1.0 (use Contact 7 form in a widget)
    List Yo' Files - Version 1.10 (traverses a specific folder to list the contents of the folder in a page or post)
    Members List - Version 3.2.2 (user list in a page)
    Really Simple CAPTCHA - Version 1.2
    s2Member - Version 3.5.5
    Hello Dolly (not active)
    Hyper Cache - Version 2.7.9 - (currently not active but will be when the site is more finished)

And of course I have the email code {add_action ('ws_plugin__s2member_during_handle_profile_modifications', 'email_profile_changes');} in s2-hacks.php but I already tested the problem with that s2-hacks.php deleted with no change.

Daine
User avatar
man-O-media
Experienced User
Experienced User
 
Posts: 117
Joined: February 10, 2011

Re: No password checking in profile form

Postby Jason Caldwell » March 23rd, 2011, 11:23 pm

Can you post a link to your site please?
We'll take a quick look to see if anything jumps right out.
~ Jason Caldwell / Lead Developer
& Zeitgeist Movie Advocate: http://www.zeitgeistmovie.com/

Is the s2Member plugin working for you? Please rate s2Member at WordPress.org.
You'll need a WordPress.org account ( comes in handy ). Then rate s2Member here Image
.
User avatar
Jason Caldwell
Lead Developer
Lead Developer
 
Posts: 4045
Joined: May 3, 2010
Location: Georgia / USA

Re: No password checking in profile form

Postby man-O-media » March 24th, 2011, 8:51 am

OK... Using the Firefox Error Console I dont see any errors.
I do get some warnings...

These two continiously fill the list:
Warning: Unknown pseudo-class or pseudo-element 'last'.
Source File: http://www.dunwoodynorth.org/dnca_wp/my-profile/
Line: 0

Warning: Unknown pseudo-class or pseudo-element 'first'.
Source File: http://www.dunwoodynorth.org/dnca_wp/my-profile/
Line: 0


These two came up once:
Warning: Unknown pseudo-class or pseudo-element 'hidden'. Dangling combinator.
Source File: http://www.dunwoodynorth.org/dnca_wp/my-profile/
Line: 0

Warning: Unexpected end of file while searching for selector.
Source File: http://www.dunwoodynorth.org/dnca_wp/my-profile/
Line: 0


After logging in and out again, I also see additional "Unknown pseudo-class or pseudo-element" warnings but still no errors.


I will add a new topic on this but the other odd thing is the TAB order of the registration form is not right. If you use TAB to navigate the form, about halfway down, pressing TAB jumps to the register button and another TAB takes you back into the rest of the form.

Many thanks, Daine
User avatar
man-O-media
Experienced User
Experienced User
 
Posts: 117
Joined: February 10, 2011

Re: No password checking in profile form

Postby man-O-media » March 25th, 2011, 8:53 am

Jason Caldwell wrote:Can you post a link to your site please?
We'll take a quick look to see if anything jumps right out.


Just in case you didn't see my last entry
http://www.dunwoodynorth.org/dnca_wp/wp ... n=register
I am using the level 0 free registration so you can register and see the whole thing.

Daine
User avatar
man-O-media
Experienced User
Experienced User
 
Posts: 117
Joined: February 10, 2011

Re: No password checking in profile form

Postby Jason Caldwell » March 26th, 2011, 2:48 am

Investigating now.
~ Jason Caldwell / Lead Developer
& Zeitgeist Movie Advocate: http://www.zeitgeistmovie.com/

Is the s2Member plugin working for you? Please rate s2Member at WordPress.org.
You'll need a WordPress.org account ( comes in handy ). Then rate s2Member here Image
.
User avatar
Jason Caldwell
Lead Developer
Lead Developer
 
Posts: 4045
Joined: May 3, 2010
Location: Georgia / USA

Re: No password checking in profile form

Postby Jason Caldwell » March 26th, 2011, 3:50 am

Thanks for reporting this important issue.

OK. This is a bug since s2Member v3.5.

This can be reproduced with the [s2Member-Profile /] Shortcode; but is working properly in the Stand-Alone version at /?s2member_profile=1.

I'm attaching a JavaScript file for you with a fix, so you can go ahead and correct this issue on your installation while you're waiting for the next release of s2Member ( v3.5.8+ ). Incidentally, I'm also including a bug fix in this JavaScript file that corrects the bug you reported here.

Please upload this file and allow it to override your existing copy.
/wp-content/plugins/s2member/includes/s2member-min.js
( then, clear your browser cache; and/or refresh the page )
s2member-min.js
(8.61 KiB) Downloaded 30 times
~ Jason Caldwell / Lead Developer
& Zeitgeist Movie Advocate: http://www.zeitgeistmovie.com/

Is the s2Member plugin working for you? Please rate s2Member at WordPress.org.
You'll need a WordPress.org account ( comes in handy ). Then rate s2Member here Image
.
User avatar
Jason Caldwell
Lead Developer
Lead Developer
 
Posts: 4045
Joined: May 3, 2010
Location: Georgia / USA

Re: No password checking in profile form

Postby man-O-media » March 26th, 2011, 3:19 pm

You be da man !!!

Both fixes seem to work fine.

Any chances of eventually adding the password strength indicator to the form?
Kind of nice both to see the password quality and also an immediate indication that the passwords match.

Daine
User avatar
man-O-media
Experienced User
Experienced User
 
Posts: 117
Joined: February 10, 2011

Re: No password checking in profile form

Postby Jason Caldwell » March 26th, 2011, 11:19 pm

Very welcome Daine.
Yes, thanks for the reminder on this. I need to push this up on the TODO list.
~ Jason Caldwell / Lead Developer
& Zeitgeist Movie Advocate: http://www.zeitgeistmovie.com/

Is the s2Member plugin working for you? Please rate s2Member at WordPress.org.
You'll need a WordPress.org account ( comes in handy ). Then rate s2Member here Image
.
User avatar
Jason Caldwell
Lead Developer
Lead Developer
 
Posts: 4045
Joined: May 3, 2010
Location: Georgia / USA

Re: No password checking in profile form

Postby allex » July 12th, 2011, 5:59 am

Hi,

I'm having the same problem(password strength indicator does'n work) using the shortecode: [s2Member-Profile /]
I have replaced the js file but it does not work for me.

Can anybody help me, this is my site http://freetotry.me, you can register here: http://freetotry.me/wp-login.php?action=register

and see the user profile after login here: http://freetotry.me/login-wecome-page/#t_user_profile

Thank you,
Alex
User avatar
allex
Registered User
Registered User
 
Posts: 5
Joined: May 26, 2011

Re: No password checking in profile form

Postby Cristián Lávaque » July 12th, 2011, 2:40 pm

allex wrote:I have replaced the js file but it does not work for me.


Why don't you try that form without changing its JavaScript? The password strength indicator uses that JS to work.
Cristián Lávaque http://s2member.net
Is s2Member working for you? Please rate it Image at WordPress.org. Thanks! :)
User avatar
Cristián Lávaque
Developer
Developer
 
Posts: 6836
Joined: December 22, 2010

Re: No password checking in profile form

Postby allex » July 13th, 2011, 10:11 am

Of course I tried the original script, when I saw that it isn't working I began googling, and I found this thread, and only after that I changed the js file.
For more information I am using MU, but I tried the form generated by Shortcode on a single instalation and I got same result - it's not working :(
I'm using the latest version of s2member framework
User avatar
allex
Registered User
Registered User
 
Posts: 5
Joined: May 26, 2011

Re: No password checking in profile form

Postby Cristián Lávaque » July 13th, 2011, 5:52 pm

I see. Have you tried -as a test- using the TwentyTen theme and deactivating all other plugins? If then the strength indicator works in your custom profile page, that means one of the things you removed conflicts with s2Member's JS. You'd need to activate one by one until it breaks again and you'll know which one is. Please let us know what you find.
Cristián Lávaque http://s2member.net
Is s2Member working for you? Please rate it Image at WordPress.org. Thanks! :)
User avatar
Cristián Lávaque
Developer
Developer
 
Posts: 6836
Joined: December 22, 2010

Re: No password checking in profile form

Postby allex » July 14th, 2011, 1:44 am

Hi,
the theme I was testing on, was using another version of jQuery. I disabled jQuery from that theme and it works perfectly.
Thank you for the hint :)

Cheers,
Alex
User avatar
allex
Registered User
Registered User
 
Posts: 5
Joined: May 26, 2011

Re: No password checking in profile form

Postby Cristián Lávaque » July 14th, 2011, 7:39 pm

I'm very glad you got it to work. :)
Cristián Lávaque http://s2member.net
Is s2Member working for you? Please rate it Image at WordPress.org. Thanks! :)
User avatar
Cristián Lávaque
Developer
Developer
 
Posts: 6836
Joined: December 22, 2010


Return to s2Member Plugin

Who is online

Users browsing this forum: Bing [Bot] and 2 guests

cron