The function c_ws_plugin__s2member_users_list::users_list_query called by the pre_user_query action is way too greedy, it doesn't consider other plugins that might already been modifying the user query. It just overwrites everything and expects others to play nicely.
Attached is my suggested improvement.
Lew
pre_user_query action is way too greedy!
s2Member Plugin. A Membership plugin for WordPress®.
2 posts
• Page 1 of 1
pre_user_query action is way too greedy!
by lewayotte » May 1st, 2011, 4:05 pm
- Attachments
-
users-list.inc.php.diff.txt- (1.64 KiB) Downloaded 26 times
-
lewayotte - Experienced User
- Posts: 33
- Joined: June 22, 2010
- Location: Athens, GA
Re: pre_user_query action is way too greedy!
by Jason Caldwell » May 3rd, 2011, 9:28 pm
Thank you VERY much.
I'm going to consider this in the next release.
@TODO: Merge changes proposed here into the pre_user_query Hook.
I'm going to consider this in the next release.
@TODO: Merge changes proposed here into the pre_user_query Hook.
~ Jason Caldwell / Lead Developer
& Zeitgeist Movie Advocate: http://www.zeitgeistmovie.com/
Is the s2Member plugin working for you? Please rate s2Member at WordPress.org.
You'll need a WordPress.org account ( comes in handy ). Then rate s2Member here
.
& Zeitgeist Movie Advocate: http://www.zeitgeistmovie.com/
Is the s2Member plugin working for you? Please rate s2Member at WordPress.org.
You'll need a WordPress.org account ( comes in handy ). Then rate s2Member here
-
Jason Caldwell - Lead Developer
- Posts: 4045
- Joined: May 3, 2010
- Location: Georgia / USA
2 posts
• Page 1 of 1
Who is online
Users browsing this forum: No registered users and 2 guests