3.5.8 breaks Success=url and notifications

[scottgould]

Hi

Not moaning at all - but 3.5.8 has broken for me:

1. the URL that I define for "success=url" in my pro-forms,
2. it has also broken notifications that come through to me on new payments,
3. it has also broken the API notifications that I used to ping them additional emails,
4. and it also meant that new registrations lost their full names that they entered.

It seems to me like it's not completing the final part of it's loop back to the site after payment.

I don't know if others have had this problem too?

I'm downgrading to 3.5.7 as we speak. I would work on a solution but the few things that I tried didn't work, and I have critical payments going through so I can't work it on and need to go back to a solid setup.

Scott

[Cristián Lávaque]

Hi Scott.

Did you use the automatic update? Did you try deleting the s2member and s2member-pro directories and uploading the new versions via FTP?

Do you have any errors in your log files?

[scottgould]

Hi Christian,

Where is the S2member log file? I will check for you.

I did automatic update. I've downgraded using FTP and now it's not working on 3.5.7 either - critical problem for me!

Thanks for your help.

Scott

[scottgould]

Hi Christian

I've checked the error logs - nothing pertaining to s2member comes up.

I've reinstalled and now it DOES the redirect and also notifies me, as well as listing the full user name.

However it still doesn't perform the API notifications to my custom scripts, and also stops before the buddypress Welcome Pack can send a custom welcome message to users.

Any ideas?

[Cristián Lávaque]

So you did the update via FTP the second time? viewtopic.php?f=36&t=247

I'm glad you recovered some of the functionality back, it's odd that you lost any to begin with and that you still have some left to come back.

I was refering to your server's error logs, but you say there's nothing there. Really odd.

You say you get some notifications but not others? Weird.

I've notified Jason, as soon as he's back he should be taking a look at this.

[scottgould]

I've been playing with this all day and have got further. Still not all back to normal, but I think I can handle this myself so as to not use Jason's and your time up.

Once I'm sorted I'll let you know

Thanks v much,
Scott

[Cristián Lávaque]

I'm very glad you're making progress. Thanks for the update, Scott.

Could you please share what you found the problems to be in your customizations, or what you did that seems to have sorted them out?

Thanks!

[scottgould]

Hi Cristián

1. The success URL seemed to be a case of uninstalling it and reinstalling it

2. The notifications weren't working because my API script wasn't working (opps!)

3. I am STILL however stuck on the name problem:

- when I test free registration, I get both names as the full name
- however when I test purchasing memberships, I only get the first name as the name, which messes my system.

I will keep plugging away

Also apologies for getting your name wrong!

Scott

80% Resolved

[Jason Caldwell]

Thanks for reporting this important issue Scott.
~ and thanks for bringing this to my attention Cristián.

- when I test free registration, I get both names as the full name
- however when I test purchasing memberships, I only get the first name as the name, which messes my system.

I just ran through a quick rounds of tests and was unable to reproduce this. But perhaps I'm missing something. Can you please tell me exactly which API Notification this is happening with?

This information will also be helpful.
1. WordPress version.
2. s2Member Pro version.
3. A copy of the Pro Form Shortcode being used.

[scottgould]

Hi Jason

Thanks for this.

I didn't have this error before - it's only been since my problems today with upgrading to 3.5.8 and subsequently fixing them. (Not complaining - S2member is awesome!)

My setup:

Wordpress 3.1.1
S2Member 3.5.8 and pro 1.5.8
Buddypress 1.2.8
(all latest)

Let me clarify what's happening:

1. When I create a free account, I have no problems.

2. When I test a membership purchase, I have problems. I ping my script from the Payment callback. It used to get the fullname of the user - now it only gets the first name with a space after. I can probably resolve this with playing with the callback parameters.

3. Then when the user is signed into Buddypress, it retains their first and last name in the user fields, but only uses their first name as their display name. This didn't happen formerly. I presume this is an issue with Wordpress' Display Name more than anything else?

Here is the Pro Form code (I am testing using small payments rather than Sandbox, as I have live payments going through)

Code: Select all

[s2Member-Pro-PayPal-Form level="2" ccaps="club" desc="Like Minds Club Membership @ £400 ex VAT, 1 year" ps="paypal" cc="GBP" ns="1" custom="wearelikeminds.com|club" ta="0" tp="0" tt="Y" ra="0.01" rp="1" rt="Y" rr="BN" accept="paypal" accept_via_paypal="paypal" coupon="" accept_coupons="0" default_country_code="" captcha="0" success="http://wearelikeminds.com/registration/club-welcome" /]

[Jason Caldwell]

Thanks for the follow-up Scott.

2. When I test a membership purchase, I have problems. I ping my script from the Payment callback. It used to get the fullname of the user - now it only gets the first name with a space after. I can probably resolve this with playing with the callback parameters.

Hmmm. This sounds like it could have something to do with data handling in your script. A space after the name would indicate to me that something in your script, or possibly in the data transfer to your script is losing URL encoded data. When it comes through the query string to your script, it will look like this:
John+Doe. That's a result of s2Member applying: urlencode($full_name)

If this problem continues, please post a copy of your API Notification URL. The one you've given s2Member. We'll be happy to have a look for you. Also, if you have a code sample you can provide, that would be helpful too. Something that shows your script and how it receives this data.

3. Then when the user is signed into Buddypress, it retains their first and last name in the user fields, but only uses their first name as their display name. This didn't happen formerly. I presume this is an issue with Wordpress' Display Name more than anything else?

This is caused by s2Member.
It's to be expected in the latest release.
However, we are working to improve upon this.
Please see: viewtopic.php?f=4&t=3081&p=9594#p9594

[scottgould]

Hi Jason

Thank you for this,

1. I have resolved the notification problem by playing around with it!

2. The first name problem - I didn't know this was a bug with S2Member. I've added a script to my notification script which rewrites the display name as both names.

Thank you Jason, much appreciated.

[Jason Caldwell]

An issue with ampersands in the success="" attribute was corrected in the latest release of s2Member v110605+ ( available now ). This may solve your problem.

From the Changelog:
http://wordpress.org/extend/plugins/s2member/changelog/

(s2Member/s2Member Pro). Bug fix. When using ampersands in the success="" Attribute, it would break Success Return URLs on some WordPress® installations. s2Member now converts these internally to avoid the issue.